Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db reconfig #10

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Db reconfig #10

merged 7 commits into from
Sep 12, 2024

Conversation

GBowman1
Copy link
Collaborator

@GBowman1 GBowman1 commented Sep 12, 2024

Type of Change

  • New Feature
  • Debugging
  • Refactor

Describe Changes Made

In this PR I reconfigured our DB SChema. The Prior way had no association between users and there created events. also the naming convention of the many to many table of users sign up for or "attending" the event created conflicts for our user to event association, now we can have a nested controller under users for users events.
I went ahead and set up routes and controllers with notes so its a easy to follow transition.
Testing will have to get sorted out for the old joins table.

PR Checklist

  • Added Reviewer
  • Followed TDD, And Test are Passing

Copy link
Collaborator

@RodrigoACG RodrigoACG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and thank you for the comments as well

@clydeautin clydeautin merged commit 2b5ffcc into main Sep 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants